[L] Change in libosmocore[master]: Add a GSM RLP decoder and encoder

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email ) Change subject: Add a GSM RLP decoder and encoder ...................................................................... Patch Set 7: (5 comments) File include/osmocom/gsm/rlp.h: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/00ac2ee0_727e5ead PS4, Line 1: /* Done https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/a05a35af_4a0e4ba0 PS4, Line 24: /*! \defgroup rlp GSM RLP (Radio Link Protocol) as used in CSD Done File src/gsm/rlp.c: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/c0ed4035_e0af9efa PS4, Line 85: //out->fcs = (data[240/8-3] << 16) | (data[240/8-2]) << 8 | (data[240/8-1] << 0); Done https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/9eb43577_a1c9b574 PS4, Line 89: if (n_s == 0x3f) { Done https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/ea8475af_4940224c PS4, Line 93: memcpy(out->info, data+2, 240/8 - 5); I actually find it easier to understand the way it is. Anyone working on RLP will know the 240 / 576 byte frame size. #define 240BITS_AS_BYTES (240/8) doesn't really make the code more readable, IMHO. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d9bd8eb4f0cd0f72c436996767b199429596917 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 7 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 28 Nov 2023 21:54:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment