Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34128 )
Change subject: gprs_bssgp_rim: add decoder for RIM ROUTING ADDRESS
......................................................................
Patch Set 1:
(2 comments)
File src/gb/gprs_bssgp_rim.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10457):
https://gerrit.osmocom.org/c/libosmocore/+/34128/comment/b7b39830_4f872cba
PS1, Line 57: int bssgp_parse_rim_ra(struct bssgp_rim_routing_info *ri, const uint8_t
*buf,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10457):
https://gerrit.osmocom.org/c/libosmocore/+/34128/comment/0793642b_87f30fb2
PS1, Line 92: ri->eutran.global_enb_id_len = len - 5;
code indent should use tabs where possible
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34128
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibca1f08906c4ffeecdae80d4e91c6c7b05fe4f8a
Gerrit-Change-Number: 34128
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 10 Aug 2023 09:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment