Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/37543?usp=email )
Change subject: pySim-shell: add "fsdump" command
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37543/comment/d78d413d_69d5eb82
PS1, Line 731: # the EF we want to export. To maintain consistency we will then
tabs vs spaces
https://gerrit.osmocom.org/c/pysim/+/37543/comment/cf7c3f6e_de14d3ad
PS1, Line 784: result[0])
don't you need to do `str()` like above?
https://gerrit.osmocom.org/c/pysim/+/37543/comment/17ebafdc_3dab3e56
PS1, Line 790: else
cosmetic: `else` is not needed after `break` or `return`
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib179f57bc04d394efe11003ba191dca6098192d3
Gerrit-Change-Number: 37543
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jul 2024 19:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment