Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30992 )
Change subject: layer23: Introduce APN VTY node
......................................................................
Patch Set 3:
(3 comments)
File src/host/layer23/include/osmocom/bb/common/apn.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/19cdf139_02da3fe3
PS3, Line 49: shut-down
this spelling looks weird, "shutdown" or "shut down"?
https://en.wikipedia.org/wiki/Shutdown
(but also not that important)
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/24f2ad6e_480f566e
PS3, Line 51: sequeence
sequence
File src/host/layer23/src/common/apn.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/4176a35b_6387c65b
PS3, Line 47: {
should it remove itself from ms->gprs.apn_list here?
otherwise it looks like with "no apn ..." vty cmd, it will still be in apn_list
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30992
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 13:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment