Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32589 )
Change subject: layer23: modem: grr: Log ignored CCCH ImmAss
......................................................................
Patch Set 3:
(3 comments)
File src/host/layer23/src/modem/grr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32589/comment/0ad4c14b_ff6819d0
PS3, Line 242: LOGL_INFO
Maybe LOGL_DEBUG instead? You gonna see lots of these
messages when running modem against a busy com […]
Yes I know, but at the current
stage I think it makes sense to have it as INFO rather than DEBUG. DEBUG means too much
stuff needs to be logged.
https://gerrit.osmocom.org/c/osmocom-bb/+/32589/comment/b8fe1a79_75cf6b80
PS3, Line 256: no req_ref match
`req_ref mismatch`?
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/32589/comment/93265166_085c3cad
PS3, Line 257: ia->req_ref.ra, ia->req_ref.t1,
alignment issues
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32589
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iaecd2616733d84f35a825916fe888142800b426b
Gerrit-Change-Number: 32589
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 May 2023 16:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment