12 Jan
2023
12 Jan
'23
2 p.m.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30948 )
Change subject: modem: request an Uplink TBF, match Immediate Assignment ......................................................................
Patch Set 1:
(2 comments)
File src/host/layer23/src/modem/app_modem.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2633): https://gerrit.osmocom.org/c/osmocom-bb/+/30948/comment/c612aac4_cdf4fd37 PS1, Line 64: } else { else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2633): https://gerrit.osmocom.org/c/osmocom-bb/+/30948/comment/08528442_c4997a23 PS1, Line 164: #if 1 Consider removing the #if 1 and its #endif
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30948
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iec0dcc629d29dec270649cf7428f71af0dfd2dbb
Gerrit-Change-Number: 30948
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 12 Jan 2023 13:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment