Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email )
Change subject: subscriber-create-on-demand: rework configuration
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
a
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/37779/comment/4933ab0f_d310fea3?usp… :
PS1, Line 300: vty_out(vty, " no subscriber-create-on-demand%s",
VTY_NEWLINE);
Well, I believe printing a setting explicitly is
better than omitting values. […]
the point IMHO is less what each of us feel at this
point, but more "what is consistent with the existing way how we do things in the
vty"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9
Gerrit-Change-Number: 37779
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2024 14:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>