Attention is currently required from: jolly, laforge, fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31417
)
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 8:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/83d976b8_6e0c796b
PS7, Line 1274: if (OSMO_UNLIKELY(rfc5993 && (resp_msg->len !=
GSM_HR_BYTES_RTP_RFC5993))) {
(The function rtppayload_is_valid sits in the RTP
receiving path) […]
> in case both or none of the flags are set both encodings are recognized as valid
formats.
Are we talking about Schrödinger's cat format here? I don't really want to enter
this kind of philosophical topics when looking at code. Make it so that if the flag is
set, the BTS lower layers support that format; if not set, it doesn't support it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 15:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment