Attention is currently required from: laforge, neels, osmith, pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-hlr/+/37780?usp=email )
Change subject: subscriber-create-on-demand: add mode for MSISDN=IMSI
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/hlr/hlr.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/37780/comment/a2fd6c50_73b3919b?usp… :
PS1, Line 46: SUBSCR_COD_MODE_IMSI,
just "mode IMSI" wasn't clear to me
until I read the code below that copies the IMSI to the MSISDN. […]
Makes sense, I
renamed it to MSISDN-from-IMSI. Thanks!
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/37780?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3470492f5e46de7246d9a74e80c37f80f455d851
Gerrit-Change-Number: 37780
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2024 19:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>