Attention is currently required from: osmith, jolly, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34132 )
Change subject: lapdm: Append RSL_IE_OSMO_ABS_FRAME_NUMBER to RSLms msgs towards upper
layers
......................................................................
Patch Set 6:
(1 comment)
File tests/lapd/lapd_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/34132/comment/1ee39af9_549da5b7
PS6, Line 362: >=
why not == with the new size?
because the new IE
is not part of the header, it's a TLV after it. Hence now msg can contain more than
only the header.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34132
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id62c18f49f270449067b25b7104eb8b47f1955ec
Gerrit-Change-Number: 34132
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Aug 2023 11:03:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment