Attention is currently required from: arehbein, fixeria, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Introduce per-BTS timers, RLC timer commands ......................................................................
Patch Set 12:
(2 comments)
File src/osmo-bsc/bts_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/06a4a40c_5c500598 PS12, Line 41: _templates
I am wondering why `_templates`? `_def` or `_defaults` maybe?
(I think the term "template" is fine and accurate, i assume no vty edits these)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/f216e673_fd0b3aa1 PS3, Line 2068:
(explanation in comment above https://gerrit.osmocom. […]
In general, the tdefs API was made modular with flexible re-use in mind.
I havent gone into the smallest details of reading this -- I might find a simplification here or there but in general, I think that this is the way to go: plug tdefs API functions to a custom vty "frontend", tailored to per-BTS timers, which is not provided by the tdefs API in itself.