Attention is currently required from: fixeria.
neels has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi
......................................................................
Patch Set 4:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39742/comment/ade6f2a3_1c874123?usp=em… :
PS4, Line 42: Subclasses have to implement the apply_val() classmethods
when i tried to detect whether a class is abstract, it
didn't work. […]
(re "it didn't work": in two ways: i could not
get is_abstract() to return True, and also it turned out that what i planned to probe the
abstract-ness for will not work out, because some "abstract" classes actually
implement the function with generic parts that subclasses call. So the
"semantic" abstractness concept in the end actually needs to be a boolean flag.
Simplest, easiest.)
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/39742?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Mar 2025 12:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>