Attention is currently required from: pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email )
Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ......................................................................
Patch Set 2:
(1 comment)
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/38958/comment/a84ca2b1_d15c468e?usp=... : PS1, Line 947: #define ENSURE_BTS_OBJECT() \
better pass "bts" as a param here, so it doesn't get magically assigned below.
shouldn't we better have something like this?:
#define ENSURE_BTS_OBJECT(bts_nr) ({ \ _bts = magic(); \ _bts; \ })