[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

Attention is currently required from: pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: ack -> separate patch File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/a82d2f8e_b7bbf94… : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name); two reasons to disagree: a) the vararg parsing is not the slow part, the talloc is. There is no optimization effect. b) IIUC this code happens when establishing links, so it is not performance relevant. So this clearly calls for avoiding code dup instead of optimizing. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:00:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>