15 Oct
2023
15 Oct
'23
2:20 p.m.
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34737?usp=email )
Change subject: tools: gtp-tunnel: add IPv6 support ......................................................................
Patch Set 1:
(1 comment)
File tools/gtp-tunnel.c:
https://gerrit.osmocom.org/c/libgtpnl/+/34737/comment/d1d5146c_c519dd2c PS1, Line 105: if (!strcmp(argv[optidx], "ip")) { probably the same question like in the other commit: should we really call ipv4 just "ip"? I don't know where this kind of notation is used. I only know ipv4/ipv6 or ip4/ip6. The only situation where I know the 4 suffix is often skipped is inet/inet6, as that's how AF_INET/AF_INET6 are called.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34737?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ifdc104b158afa6343e3aa6142ffa9591db209c4f
Gerrit-Change-Number: 34737
Gerrit-PatchSet: 1
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Sun, 15 Oct 2023 12:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment