[L] Change in osmo-bts[master]: refactor: replace rtppayload_is_valid() with preening before enqueue

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32988 ) Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/a843fb16_71ee5870 PS1, Line 1237: default: you are dropping the AMR path here. Why? sysmobts really requires octet-aligned. It was noted that passing a bwe AMR frame to the firmware generates a kernel crash. File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/ffbb1e5b_1d3d2079 PS1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case I understood this extra byte was only appearing in HR? Osmux is AMR always, does it really apply here? https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/d45f3b1f_457e0403 PS1, Line 422: case PL_DECISION_STRIP_HDR_OCTET: according to rtp_payload_input_preen() implemenmtation this cannot happen for AMR? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7fc99aeecba8303b56d397b8952de5eea82b301e Gerrit-Change-Number: 32988 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 25 May 2023 08:49:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment