Attention is currently required from: falconia.

Patch set 1:Code-Review -1

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #1, Line 1237: default:

    you are dropping the AMR path here. Why?
    sysmobts really requires octet-aligned. It was noted that passing a bwe AMR frame to the firmware generates a kernel crash.

• File src/common/osmux.c:

  • Patch Set #1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case

    I understood this extra byte was only appearing in HR? Osmux is AMR always, does it really apply here?

  • Patch Set #1, Line 422: case PL_DECISION_STRIP_HDR_OCTET:

    according to rtp_payload_input_preen() implemenmtation this cannot happen for AMR?

To view, visit change 32988. To unsubscribe, or for help writing mail filters, visit settings.