Attention is currently required from: jolly, laforge, fixeria, msuraev.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32687 )
Change subject: paging: cosmetic: rename all IMM.ASS references to MACBLOCK
......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS1:
it looks like this is a purely cosmetic rename. […]
Yes, its cosmetic, no logic changed.
File src/common/paging.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32687/comment/dbdb9fa1_96d1cd86
PS1, Line 63: paging
`normal`? given that `PAGING_RECORD_PAGING` becomes `PAGING_RECORD_NORMAL`.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/32687/comment/cf06f4d7_15ba2deb
PS1, Line 270: MACBLOCK message
"MACBLOCK message" sounds weird, just say "MAC block"?
Done
https://gerrit.osmocom.org/c/osmo-bts/+/32687/comment/05863a0e_cd2ff87a
PS1, Line 289: macblock
MAC block
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32687
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad
Gerrit-Change-Number: 32687
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: msuraev
msuraev@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Mon, 15 May 2023 10:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
