27 Jan
2022
27 Jan
'22
5:43 p.m.
Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 )
Change subject: ranap_rab_ass: add decoder and rewrite functions for
RAB-AssignmentRequest/Response
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
This is not finished yet. There is still some stuff to cleanup and there is also the
following problem:
At the moment we use ranap_cn_rx_co and ranap_ran_rx_co as decoders. Those functions take
a callback that is called with the decoded ranap_message container, but when the callback
is done the ranap_message is freed again. It works fine that way, but this API is very
clumsy to use. I have looked at ranap_cn_rx_co and I think it is possible to add a
ranap_cn_rx_co_decode() and ranap_cn_rx_co_free() that give the user direct access to the
ranap_message container. This would give us a lot more flexibility. We could do the decode
once when the RAB Assignment Request/Response is intercepted and do the free when the FSM
is cleaned up. This also saves us the additional decode we would need when we check the
Procedure code. So that would be the next step, adding the _free and _decode functions to
osmo_iuh and then using them here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837
Gerrit-Change-Number: 26792
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment