Attention is currently required from: fixeria, jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email )
Change subject: soft_uart: implement the transmitter ......................................................................
Patch Set 4:
(1 comment)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/991cb7b7_fb24c1dd PS4, Line 206: msgb_pull_u8 what if the msgb doesn't have anything to pull anymore? Ah, I guess that's why you check msg->len above. It would be more elegant to avoid dereferencing msgb internals and instead use msgb_length(msg) here.
The Linux kernel has the even more elegant skb_may_pull(skb, num_of_bytes) function, which sadly seems we didn't add to our msgb code.