Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28691
)
Change subject: sbcap_server: Fix double-free of rx msg if conn is destroyed
......................................................................
Patch Set 1:
(1 comment)
File src/sbcap_server.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28691/comment/5f65d153_b30b3bc3
PS1, Line 62: msgb_alloc_c
I would simply use msgb_alloc() here, which uses
dedicated 'msgb' context.
I already changed this in a previous review, which
made this crash. TBH I don't care, any of the 2 is good for me, so let's simply
merge this.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28691
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I201f44efa24a514e0087b6dcd01115b9b2b8e9db
Gerrit-Change-Number: 28691
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jul 2022 17:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment