Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/28986
)
Change subject: GTP mockup: allow single GTP devices in mockup mode
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/3519200c_45a82711
PS1, Line 16: The GTP mockup was first introduced for VTY tests during 'make
check'.
ok, you needed mockup mode to run unit tests.
https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/79de3e4c_d7ca75ed
PS1, Line 20: TTCN3 tests do query osmo-upf to list currently active tunnels, so the
why do you need mockup mode in TTCN3 in first place?
Why doesn't open5gs-upfd or osmo-ggsn need it when we run ttcn3 tests?
What's really the use case of having some mocked devices and some not? I'm really
not following your needs here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Aug 2022 15:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment