Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email )
Change subject: runtime: refactor file selection methods select and select_file
......................................................................
Patch Set 4:
(2 comments)
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/34932/comment/0ca99f6a_1263e04f
PS3, Line 357: failes
fails (without 'e')
Done
https://gerrit.osmocom.org/c/pysim/+/34932/comment/68ed37cd_7fea7177
PS3, Line 383: f = sels[name]
unused? you're doing `sels[name]` below...
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ae213f3b078983f3e6d4c11db38fdbe504c84f2
Gerrit-Change-Number: 34932
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Dec 2023 09:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment