Attention is currently required from: laforge, osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35207?usp=email )
Change subject: util: add osmo_strbuf macros to manipulate the strbuf tail
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/35207/comment/72c04f8d_08e8abc0
PS1, Line 329: } while (0)
(not related to here, macros are cool to get the actual source line/file indicated in logging, and f […]
I added real functions for the implementation, making them much more readable as a side effect, but i also kept the macros so the OSMO_STRBUF(sb, ...) pattern remains consistent in osmo_strbuf usage.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35207?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I997707c328eab3ffa00a78fdb9a0a2cbe18404b4
Gerrit-Change-Number: 35207
Gerrit-PatchSet: 1
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Wed, 06 Dec 2023 02:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment