18 Jul
2022
18 Jul
'22
11:41 a.m.
Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602
)
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Patch Set 9: Code-Review+1
(12 comments)
File debian/control:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/08493be6_7a64df3c
PS8, Line 18: libsctp-dev,
contrib/osmo-cbc.spec.in also needs to be adjusted,
this should do it: […]
Done
File include/osmocom/cbc/sbcap_server.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/dd18fcc7_e54af511
PS8, Line 3: //#include <osmocom/gsm/sbcap.h>
commented out include?
Done
File src/cbc_main.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/5e15267e_4fb68225
PS8, Line 284: binidng
binding
Done
File src/sbcap_msg.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/60c20516_1b4386f6
PS8, Line 3: /* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
(copyright 2022, also in other files?)
Done
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/459d6306_6938fa49
PS8, Line 40: #if 0
Because it shows how to encode a list of items when we
add support for it in the future. […]
Ack
File src/sbcap_server.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/373c3b5f_31d40ff2
PS8, Line 62: 1500
should be a valid talloc context instead. […]
Done
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/11af34db_bfaa3bff
PS8, Line 184: /* FIXME */
It's just kept to be on par with CBSP code, so
that it can be fixed/figured out together later.
Ack
File src/sbcap_server_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/e56c66d7_31cd4213
PS8, Line 71: //SBcAP_SBC_AP_PDU_t *pdu;
not needed?
Done
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/71120dab_32f0bf5d
PS8, Line 78: //pdu = data;
Not needed yet, but it's still worth leaving it
commented out so that readers know which pointer is […]
Ack
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/34be949e_65f1d32b
PS8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */
I left it on purpose, to understand what's this 5.
[…]
Ack
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/71abee85_6766cddb
PS8, Line 228: xpected
expected
Done
File src/smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/0d8366f2_d309ab4d
PS8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL;
Same, it's useful to keep for further future
development.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 09:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment