Attention is currently required from: pespin, fixeria.
Patch set 9:Code-Review +1
12 comments:
File debian/control:
Patch Set #8, Line 18: libsctp-dev,
contrib/osmo-cbc.spec.in also needs to be adjusted, this should do it: […]
Done
File include/osmocom/cbc/sbcap_server.h:
Patch Set #8, Line 3: //#include <osmocom/gsm/sbcap.h>
commented out include?
Done
File src/cbc_main.c:
Patch Set #8, Line 284: binidng
binding
Done
File src/sbcap_msg.c:
Patch Set #8, Line 3: /* (C) 2019 by Harald Welte <laforge@gnumonks.org>
(copyright 2022, also in other files?)
Done
Patch Set #8, Line 40: #if 0
Because it shows how to encode a list of items when we add support for it in the future. […]
Ack
File src/sbcap_server.c:
should be a valid talloc context instead. […]
Done
Patch Set #8, Line 184: /* FIXME */
It's just kept to be on par with CBSP code, so that it can be fixed/figured out together later.
Ack
File src/sbcap_server_fsm.c:
Patch Set #8, Line 71: //SBcAP_SBC_AP_PDU_t *pdu;
not needed?
Done
Patch Set #8, Line 78: //pdu = data;
Not needed yet, but it's still worth leaving it commented out so that readers know which pointer is […]
Ack
Patch Set #8, Line 148: /* static const long asn_VAL_1_SBcAP_id_Message_Identifier = 5; */
I left it on purpose, to understand what's this 5. […]
Ack
Patch Set #8, Line 228: xpected
expected
Done
File src/smscb_peer_fsm.c:
Patch Set #8, Line 311: //SBcAP_SBC_AP_PDU_t *pdu = NULL;
Same, it's useful to keep for further future development.
Ack
To view, visit change 28602. To unsubscribe, or for help writing mail filters, visit settings.