Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email )
Change subject: Use polling based LAPDm with frame numbers
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/64726ec3_cb5faf75
PS2, Line 1975: (fn + GSM_MAX_FN - 1) % GSM_MAX_FN
Hmm, I don't see any changes. […]
Done
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/9c037231_a603d3cc
PS3, Line 686: #if 0
Yes, this makes sense.
Still missing to log a
message, but not critical I guess.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd
Gerrit-Change-Number: 35007
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 21 Nov 2023 17:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment