Attention is currently required from: neels, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Update multiaddr helper ......................................................................
Patch Set 9:
(6 comments)
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/d53f555c_f92e43e0 PS9, Line 206: buf_len There is no 'buf_len' anymore. And it looks like this comment was initially incorrect: it should be host_count/addrs_count I guess?
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/929275f4_7dc7d54a PS9, Line 211: const char **hosts, size_t host_count, cosmetic: alignment needs to be fixed here
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/e19adda9_0983c84b PS9, Line 220: I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the same time.
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/1504e0df_a1cc8835 PS9, Line 236: if (hosts[i]) Before your patch this function would print "0.0.0.0" if hosts[i] is NULL. You're changing it to not print anything. What's your motivation?
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/eb09c2cb_42c8e947 PS9, Line 241: LOGL_DEBUG LOGL_ERROR? Not sure if we need to log anything here though.
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/eeab4d3a_6d3e68f1 PS9, Line 749: 512 Better do sizeof(strbuf).