Attention is currently required from: neels, pespin, msuraev.

View Change

6 comments:

• File src/socket.c:

  • Patch Set #9, Line 206: buf_len

    There is no 'buf_len' anymore. And it looks like this comment was initially incorrect: it should be host_count/addrs_count I guess?

  • Patch Set #9, Line 211: const char **hosts, size_t host_count,

    cosmetic: alignment needs to be fixed here

  • Patch Set #9, Line 220:

    I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the same time.

  • Patch Set #9, Line 236: if (hosts[i])

    Before your patch this function would print "0.0.0.0" if hosts[i] is NULL.
    You're changing it to not print anything. What's your motivation?

  • Patch Set #9, Line 241: LOGL_DEBUG

    LOGL_ERROR? Not sure if we need to log anything here though.

  • Patch Set #9, Line 749: 512

    Better do sizeof(strbuf).

To view, visit change 28993. To unsubscribe, or for help writing mail filters, visit settings.