[M] Change in pysim[master]: [4/6] personalization: refactor Pin, Adm

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email ) Change subject: [4/6] personalization: refactor Pin, Adm ...................................................................... Patch Set 3: -Code-Review (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39744/comment/7ef4d6b0_4e20244d?usp=em… : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type) * I think from an ISO7816 and UICC point of view it's sadly not correct to limit to MF. The MF has PINs, and each application on a card (e.g. USIM or ISIM application on a typical telecom card) may have its own set of application PINs. I haven't really seen any use of that, though. And I'm not sure what eSIM profiles support in that regard, please check the SAIP spec. * Regarding the ProfileElementList: I think we have to distinguish an acutal plain list in the python sense, from the decoded asn.1 structures of the SAIP PEList definition. If you come up with a better way to name and/or logically represent those two in the code: be my guest. For sure it would be elegant not having to reimplement things. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54aef10b6d4309398d4b779a3740a7d706d68603 Gerrit-Change-Number: 39744 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>