Attention is currently required from: laforge, pespin.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32184 )
Change subject: codec: add SID preening functions for FR & EFR
......................................................................
Patch Set 5:
(3 comments)
File src/codec/gsm610.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/66608f22_2ddface9
PS3, Line 428: /* should never be reached */
: return false;
I agree with OSMO_ASSERT() approach, and I shall
implement it in the next iteration.
Done
File src/codec/gsm610.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/e6cb48b9_72cea721
PS4, Line 432: return false;
Looking closer, I see that you are right - the macro
definition of OSMO_ASSERT() and the declaration […]
Done
File src/codec/gsm660.c:
https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/2e1d955c_b968c31a
PS3, Line 391:
likewise here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32184
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iec5c1f2619a82499f61cb3e5a7cd03ff0f020ad8
Gerrit-Change-Number: 32184
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 14:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment