Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32014 )
Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File include/osmocom/gsm/protocol/gsm_04_08.h:
https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/89fce96b_70e7a455 PS1, Line 1779: GSM48_IE_CIP_MODE_SET In osmo-bsc.git I see this IEI used as follows:
msgb_v_put(msg, GSM48_IE_CIP_MODE_SET | (cms & 0x0f));
so your patch is fixing libosmocore, but breaking osmo-bsc and potentially other projects.
File src/gsm/tlv_parser.c:
https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/50066660_7cd50211 PS1, Line 244: & 0xf0 Applying the mask in not needed anymore, given that you shift `uint8_t`?