Attention is currently required from: pespin.

Patch set 1:Code-Review -1

View Change

2 comments:

• File include/osmocom/gsm/protocol/gsm_04_08.h:

  • Patch Set #1, Line 1779: GSM48_IE_CIP_MODE_SET

    In osmo-bsc.git I see this IEI used as follows:

      msgb_v_put(msg, GSM48_IE_CIP_MODE_SET | (cms & 0x0f));

    so your patch is fixing libosmocore, but breaking osmo-bsc and potentially other projects.

• File src/gsm/tlv_parser.c:

  • Patch Set #1, Line 244: & 0xf0

    Applying the mask in not needed anymore, given that you shift `uint8_t`?

To view, visit change 32014. To unsubscribe, or for help writing mail filters, visit settings.