Change in osmo-ttcn3-hacks[master]: sgsn: Add TC_attach_timeout_after_pdp_act

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 ) Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ...................................................................... Patch Set 1: (5 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/2fb0a383_67e7… PS1, Line 1020: private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr { Is there an associated OS# ticket? may be worth adding it on top of the function together with quick explanation of what the test does. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/2739d9b4_fcab… PS1, Line 1023: const integer ran_index := 0, gmm_attach_repeats := 5; please in general one variable per line, specially if you are initializing them. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/8a7da972_9a6c… PS1, Line 1024: /* Standard T3350 value */ is tha standard as per spec? which one? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/17ed155d_cc58… PS1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B; do we really need this lines changing capabilities? I don't think so? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/6f05dbe5_9459… PS1, Line 1044: log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs"); by repeats here I guess you mean retransmits? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53 Gerrit-Change-Number: 31199 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 20:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment