Attention is currently required from: arehbein.

View Change

5 comments:

• File sgsn/SGSN_Tests.ttcn:

  • Patch Set #1, Line 1020: private function f_TC_attach_timeout_after_pdp_act(charstring id) runs on BSSGP_ConnHdlr {

    Is there an associated OS# ticket? may be worth adding it on top of the function together with quick explanation of what the test does.

  • Patch Set #1, Line 1023: const integer ran_index := 0, gmm_attach_repeats := 5;

    please in general one variable per line, specially if you are initializing them.

  • Patch Set #1, Line 1024: /* Standard T3350 value */

    is tha standard as per spec? which one?

  • Patch Set #1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;

    do we really need this lines changing capabilities? I don't think so?

  • Patch Set #1, Line 1044: log("Trying to receive ", gmm_attach_repeats, " ATTACH ACCEPTs");

    by repeats here I guess you mean retransmits?

To view, visit change 31199. To unsubscribe, or for help writing mail filters, visit settings.