Attention is currently required from: pespin.
neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email )
Change subject: mgw: Decouple SDP parsing step from conn obj update ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3: so nice to see some sanity spawning in that code
File include/osmocom/mgcp/mgcp_protocol.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/269526f2_938d7233?usp=... : PS3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1) duplicate -1
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/d25e34cc_7432081c?usp=... : PS3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0) (i prefer enums)
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/1d62a7ff_5850cd44?usp=... : PS3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */ (comments deserve their own separate line plz)