Attention is currently required from: pespin.

View Change

4 comments:

• Patchset:

  • Patch Set #3:

    so nice to see some sanity spawning in that code

• File include/osmocom/mgcp/mgcp_protocol.h:

  • Patch Set #3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1)

    duplicate -1

  • Patch Set #3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0)

    (i prefer enums)

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */

    (comments deserve their own separate line plz)

To view, visit change 39248. To unsubscribe, or for help writing mail filters, visit settings.