dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 )
Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ......................................................................
Patch Set 15:
(1 comment)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab_... File src/osmo-hnbgw/ranap_rab_ass.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab_... PS14, Line 198: int ranap_rab_ass_req_extract_inet_addr(struct osmo_sockaddr *addr, uint8_t *rab_id, RANAP_RANAP_PDU_t *ranap_pdu)
Why not passing RANAP_RAB_AssignmentRequestIEs_t here instead of RANAP_RANAP_PDU_t?
That is possible, but then the usage of those functions get more complicated as caller then has to take care about the decoding and of course the freeing of the memory afterwards.
What advantage do you see?