Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32236 )
Change subject: Merge gsm_network into gsm_bts_sm and place gsm_bts under it ......................................................................
Patch Set 4:
(5 comments)
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/489e1cde_858a2437 PS4, Line 406: g_bts_sm->num_bts++; I find this weird that a BTS is added to `&g_bts_sm->bts_list` in `gsm_bts_alloc()`, but `g_bts_sm->num_bts` is incremented here. Any reason why not doing both in a single place?
File src/common/bts_sm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/5db95b4f_626a08c0 PS4, Line 37: talloc_free talloc does free() all its children anyway, do we really need to do this manually?
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/303c0b76_a4442e9a PS4, Line 154: if (!bts) { `OSMO_UNLIKELY`?
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/f3386730_2dd687d2 PS4, Line 897: struct gsm_bts_sm *bts_sm Can we remove this argument since `g_bts_sm` is available globally?
https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/cbdf3323_bafcfcd0 PS4, Line 957: struct gsm_bts_sm *bts_sm Can we remove this argument since `g_bts_sm` is available globally?