27 Apr
2025
27 Apr
'25
5:42 a.m.
Attention is currently required from: lynxis lazus, pespin.
neels has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email )
Change subject: rua: Handle event TX_DIRECT_TRANSFER in disconnected state discarding msg
......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1:
IMHO this patch should not modify the event handler function,
but only add the event to the list of permitted events.
The larger part of this patch seems like a workaround for a customer not providing a
pcap...
File src/osmo-hnbgw/context_map_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162/comment/3b3c727c_fcfaf6e7?u… :
PS1, Line 285: condition
We have data to be sent out on RUA, but RUA is already disconnected.
This can happen for any forsaken reason (RAN disconnected, CN disconnected, something went
wrong on layer 2, ...) and we can't make any detailed statement here other than that.
I believe this isn't called a race condition, is it
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162/comment/f62ebfa0_021631e9?u… :
PS1, Line 290: msgb_l2len(ranap_msg), osmo_hexdump(msgb_l2(ranap_msg),
msgb_l2len(ranap_msg)));
I think we should not print entire messages' hexdump on NOTICE.
can we put the log message on DEBUG instead?
It might make sense to log the dry fact on NOTICE,
and additionally, separately the hexdump on DEBUG,
and sanity-limit the hexdump length?
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162/comment/ddeb620e_8eea5a36?u… :
PS1, Line 295: all
it's no longer all events
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40162?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id68f219ce776fbbfaa80d3b3ed976f48bef4f883
Gerrit-Change-Number: 40162
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 27 Apr 2025 03:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No