Attention is currently required from: lynxis lazus, pespin.
4 comments:
Patchset:
IMHO this patch should not modify the event handler function,
but only add the event to the list of permitted events.
The larger part of this patch seems like a workaround for a customer not providing a pcap...
File src/osmo-hnbgw/context_map_rua.c:
Patch Set #1, Line 285: condition
We have data to be sent out on RUA, but RUA is already disconnected.
This can happen for any forsaken reason (RAN disconnected, CN disconnected, something went wrong on layer 2, ...) and we can't make any detailed statement here other than that.
I believe this isn't called a race condition, is it
Patch Set #1, Line 290: msgb_l2len(ranap_msg), osmo_hexdump(msgb_l2(ranap_msg), msgb_l2len(ranap_msg)));
I think we should not print entire messages' hexdump on NOTICE.
can we put the log message on DEBUG instead?
It might make sense to log the dry fact on NOTICE,
and additionally, separately the hexdump on DEBUG,
and sanity-limit the hexdump length?
it's no longer all events
To view, visit change 40162. To unsubscribe, or for help writing mail filters, visit settings.