12 Dec
2023
12 Dec
'23
3:47 p.m.
Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email )
Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full
set of addresses
......................................................................
Patch Set 3:
(3 comments)
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/b0d63bfa_5fe477d1
PS3, Line 364: "<need-more-bufs!>"
* result mixed with an error message: better than
return silently a truncated output. […]
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/5deac102_577229a7
PS3, Line 371: NULL in case of error
But you're actually changing the API: this
function does not return NULL on error anymore, but would […]
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/aaeafc05_6cee105e
PS3, Line 467: get_local_sockname_buf
what would you suggest to do instead? I don't see
anything interesting/worth here.
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I216502a9aeafe638940f110bc9fddf2504b2ac3a
Gerrit-Change-Number: 35287
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Dec 2023 14:47:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment