Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37947?usp=email )
Change subject: suci-tutorial: add section about SUCI calculation by the USIM
......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/37947/comment/02772999_a391859e?usp=em… :
PS1, Line 9: The tutorial describes how SUCI calculation in the UE is configure,
+d
https://gerrit.osmocom.org/c/pysim/+/37947/comment/245a5635_f55881bb?usp=em… :
PS1, Line 10: ad
+d
File docs/suci-tutorial.rst:
https://gerrit.osmocom.org/c/pysim/+/37947/comment/6d2ff52a_12adef99?usp=em… :
PS1, Line 204: The sysmoISIM-SJA5-S17 *SUCI
Looks like something is missing here, like "The sysmoISIM-SJA5-S17 supports
...".
https://gerrit.osmocom.org/c/pysim/+/37947/comment/43966f10_8fa93a1e?usp=em… :
PS1, Line 227: changed
s/changed/changes/
https://gerrit.osmocom.org/c/pysim/+/37947/comment/25af0b96_0c6b6177?usp=em… :
PS1, Line 230: as well
maybe say "in addition to service 124" to make it cleaner?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37947?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I45d47f9278b30d99ebde6891de0ba8cc74b1a0a0
Gerrit-Change-Number: 37947
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Aug 2024 04:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No