Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32932 )
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008
......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/gsm/gsm0808.h:
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/dd882dce_f74262b7
PS5, Line 386: struct sockaddr_storage *aoip_transport_layer;
why did you change this to be a pointer? it
doesn't match with most structures here and in general i […]
It is the same way
it was done in "struct gsm0808_handover_request". When not using a pointer, all
users of that header file must have knowledge of struct sockaddr_storage and therefore
must include sys/socket.h. This seems not be available on all system, so jenkins builder
failed in the first place yesterday.
I think this is not a problem. The structures are not stored somewhere. They are just used
to encode/decode messages, so they are on stack memory until the transcoding is finished.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32932
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
Gerrit-Change-Number: 32932
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 May 2023 07:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment