Attention is currently required from: pespin.

View Change

1 comment:

• File include/osmocom/gsm/gsm0808.h:

  • Patch Set #5, Line 386: struct sockaddr_storage *aoip_transport_layer;

    why did you change this to be a pointer? it doesn't match with most structures here and in general i […]

    It is the same way it was done in "struct gsm0808_handover_request". When not using a pointer, all users of that header file must have knowledge of struct sockaddr_storage and therefore must include sys/socket.h. This seems not be available on all system, so jenkins builder failed in the first place yesterday.

    I think this is not a problem. The structures are not stored somewhere. They are just used to encode/decode messages, so they are on stack memory until the transcoding is finished.

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.