13 Nov
2024
13 Nov
'24
8:17 p.m.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email )
Change subject: gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp
......................................................................
Patch Set 1:
(18 comments)
File src/gsm/gsm23003.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/bdd630ec_da86cea8?… :
PS1, Line 666: if (a->group_id < b->group_id)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/061155dc_565c3cd0?… :
PS1, Line 667: return -1;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/d59d47de_c76d1cf2?… :
PS1, Line 667: return -1;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/1167502f_3330eed8?… :
PS1, Line 668: if (a->group_id > b->group_id)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/88a1fc4c_fd49eec7?… :
PS1, Line 669: return 1;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/cc7d5ea8_f5f0720a?… :
PS1, Line 669: return 1;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/e6aaeae8_c0bbcafa?… :
PS1, Line 671: if (a->code < b->code)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/3c0501dc_4f1ba89d?… :
PS1, Line 672: return -1;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/f6de698a_71f739c6?… :
PS1, Line 672: return -1;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/4f42c6b5_7eb17492?… :
PS1, Line 673: if (a->code > b->code)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/9737fef9_b799442a?… :
PS1, Line 674: return 1;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/833453fb_58c879e8?… :
PS1, Line 674: return 1;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/9beb52ea_9baeb7b4?… :
PS1, Line 676: return 0;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/eb6119aa_d0f4a029?… :
PS1, Line 686: int rc = osmo_plmn_cmp(&a->plmn, &b->plmn);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/84bca2ed_68e992ab?… :
PS1, Line 687: if (rc)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/e738c1d5_f32f674f?… :
PS1, Line 688: return rc;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/21f25b35_b90a2f46?… :
PS1, Line 688: return rc;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):
https://gerrit.osmocom.org/c/libosmocore/+/38763/comment/58f2d6c2_fba3d532?… :
PS1, Line 690: return osmo_mme_id_cmp(&a->mme, &b->mme);
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9a6769b1bff16450046181b31a8762ff49955ae4
Gerrit-Change-Number: 38763
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 Nov 2024 19:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No