View Change

18 comments:

• File src/gsm/gsm23003.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 666: if (a->group_id < b->group_id)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 667: return -1;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 667: return -1;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 668: if (a->group_id > b->group_id)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 669: return 1;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 669: return 1;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 671: if (a->code < b->code)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 672: return -1;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 672: return -1;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 673: if (a->code > b->code)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 674: return 1;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 674: return 1;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 676: return 0;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 686: int rc = osmo_plmn_cmp(&a->plmn, &b->plmn);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 687: if (rc)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 688: return rc;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 688: return rc;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19889):

    Patch Set #1, Line 690: return osmo_mme_id_cmp(&a->mme, &b->mme);

    please, no spaces at the start of a line

To view, visit change 38763. To unsubscribe, or for help writing mail filters, visit settings.