Attention is currently required from: pespin, msuraev.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30971 )
Change subject: layer23: Initialize osmocom_ms further in common code
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/layer23/src/common/ms.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30971/comment/1237b7b7_13cfdb12
PS1, Line 33: ms->name = talloc_strdup(ms, name);
because one thing is what user establishes in VTY and the other is the internal talloc name which ca […]
The reason to keep talloc_strdup() here is because this patch is moving previous code.
But talloc_strdup() is only needed when ms->name can change, so that we can talloc_free(ms->name) safely upon changing the name.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30971
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic629cf229167ddd4c533a2abf1b82ad78d1144a9
Gerrit-Change-Number: 30971
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-CC: msuraev
msuraev@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Sun, 15 Jan 2023 23:34:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment