Change in libosmocore[master]: logging: add log level cache

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 ) Change subject: logging: add log level cache ...................................................................... Patch Set 1: (8 comments) File src/logging.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/2f9527d3_3627704f PS1, Line 99: volatile uint8_t* log_level_lookup_cache; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/f8c82eb8_95b54a1f PS1, Line 102: static void log_cache_update_all() { Bad function definition - void log_cache_update_all() should probably be void log_cache_update_all(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/cc6f3062_db961a85 PS1, Line 102: static void log_cache_update_all() { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/b05fe2bd_e6288237 PS1, Line 125: void log_update_cache(int mapped_subsys, uint8_t enabled, uint8_t level) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/54334c9d_f07ddc5d PS1, Line 127: struct log_category tmp = {99,0}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/80c39ad5_b9fbf12d PS1, Line 141: static bool log_check_quick(int mapped_subsys, int level) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/ec2c3852_576438e9 PS1, Line 1147: const struct log_info_cat* c = &osmo_log_info->cat[i]; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/ae0b612b_595e85b5 PS1, Line 1531: if (!log_level_lookup_cache ) { space prohibited before that close parenthesis ')' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 16 Dec 2022 16:03:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment