8 comments:
File src/logging.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 99: volatile uint8_t* log_level_lookup_cache;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 102: static void log_cache_update_all() {
Bad function definition - void log_cache_update_all() should probably be void log_cache_update_all(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 102: static void log_cache_update_all() {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 125: void log_update_cache(int mapped_subsys, uint8_t enabled, uint8_t level) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 127: struct log_category tmp = {99,0};
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 141: static bool log_check_quick(int mapped_subsys, int level) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 1147: const struct log_info_cat* c = &osmo_log_info->cat[i];
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1998):
Patch Set #1, Line 1531: if (!log_level_lookup_cache ) {
space prohibited before that close parenthesis ')'
To view, visit change 30633. To unsubscribe, or for help writing mail filters, visit settings.